Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Combo charts #1199

Merged
merged 65 commits into from
Oct 10, 2023
Merged

feat: Add Combo charts #1199

merged 65 commits into from
Oct 10, 2023

Conversation

bprusinowski
Copy link
Collaborator

@bprusinowski bprusinowski commented Sep 29, 2023 •
edited
Loading

This PR adds a new group of charts – Combo charts – that includes three new chart types:

  • multi-line chart,
  • dual-axis line chart,
  • line-column chart.

Multi-line chart

Available to use when there are at least two numerical measures with the same unit available.

Dual-axis line chart

Available to use when there are at least two numerical measures with different units available.

Line-column line chart

Available to use when there are at least two numerical measures with different units available.

TODO

  • Current UI options to modify Y fields were implemented without a design and should be considered drafts. We'll need to update them once the concept is ready
  • Add translations (dependent on the above)
  • Should we disable selecting measures without units?
  • Nice to have: align the colors across column chart and other charts (do not use primary.main)
  • Nice to have: line animations

@vercel
Copy link

vercel bot commented Sep 29, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
visualization-tool ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 6, 2023 8:29am

@bprusinowski bprusinowski marked this pull request as ready for review October 6, 2023 08:11
@bprusinowski bprusinowski requested a review from ptbrowne as a code owner October 6, 2023 08:11
@sosiology sosiology linked an issue Oct 6, 2023 that may be closed by this pull request
Plot more than a single measure #439
Closed
Base automatically changed from feat/dashboards-1 to main October 10, 2023 09:17
@bprusinowski bprusinowski merged commit 3f5fb3d into main Oct 10, 2023
2 of 3 checks passed
@bprusinowski bprusinowski deleted the feat/combo-chart branch October 10, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptbrowne ptbrowne Awaiting requested review from ptbrowne

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Plot more than a single measure
1 participant
@bprusinowski